]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: make cmpstackvarlt properly asymmetric
authorMatthew Dempsky <mdempsky@google.com>
Sun, 21 Feb 2016 05:36:12 +0000 (21:36 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Mon, 22 Feb 2016 00:09:36 +0000 (00:09 +0000)
commit5609a48931593a0ba88cab4a54ea5c426b292c3e
tree6f988477f7e14271cda6425001111df4158e618e
parent8847a5913a5970b5f5c062f767c369da683648d6
cmd/compile: make cmpstackvarlt properly asymmetric

Previously, given two Nodes n1 and n2 of different non-PAUTO classes
(e.g., PPARAM and PPARAMOUT), cmpstackvarlt(n1, n2) and
cmpstackvarlt(n2, n1) both returned true, which is nonsense.

This doesn't seem to cause any visible miscompilation problems, but
notably fixing it does cause toolstash/buildall to fail.

Change-Id: I33b2c66e902c5eced875d8fbf18b7cfdc81e8aed
Reviewed-on: https://go-review.googlesource.com/19778
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/gc/pgen.go
src/cmd/compile/internal/gc/pgen_test.go