]> Cypherpunks repositories - gostls13.git/commit
cmd/dist, internal/platform: remove some target modes that fail
authorIan Lance Taylor <iant@golang.org>
Tue, 31 Jan 2023 21:55:19 +0000 (13:55 -0800)
committerGopher Robot <gobot@golang.org>
Wed, 1 Feb 2023 10:06:08 +0000 (10:06 +0000)
commit56a14ad4bc19d5ee9d4257f370a570377e81e544
treee69d2bef76c350beadcca04bb5d64ec28d71e2ad
parent23c0121e4eb259cc1087d0f79a0803cbc71f500b
cmd/dist, internal/platform: remove some target modes that fail

Before CL 463992 there were some cases that cmd/dist did not test
but that platform.BuildModeSupport permitted. In CL 463992 those
conflicts were resolved in favor of platform.BuildModeSupport.
However, further testing has uncovered some cases that do not in
fact work. Adjust those in both cmd/dist and internal/platform.

In particular, mark android-arm and android-arm64 as not supporting
plugin mode.  Sample failure:
    https://build.golang.org/log/ebba858ea9f94f076966d8cfd42348a0e9345095

Mark ios as not supporting c-archive mode.  Sample failure:
    https://build.golang.org/log/e78a58189d94b90dc6d4b2e01a1b4a0b35d63792

Fixes #58170
Fixes #58172

Change-Id: Ic1bd18e36382cac0779aad48cb6e7b1de8eeb10d
Reviewed-on: https://go-review.googlesource.com/c/go/+/464339
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/dist/test.go
src/internal/platform/supported.go