]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: update comment about x86 nop instruction generator
authorKeith Randall <khr@google.com>
Tue, 15 Jan 2019 23:00:43 +0000 (15:00 -0800)
committerKeith Randall <khr@golang.org>
Tue, 26 Feb 2019 20:41:14 +0000 (20:41 +0000)
commit57976fe2b4cbd44d27e27af510494de0d182e703
treea14580932dfe02fe26710d0cd35d5d242f7baf2d
parent5cf4e442a5dc1f4a1d6f3fd04b1083bc192e648e
cmd/compile: update comment about x86 nop instruction generator

The comment about losing the high bits is incorrect.  We now use these
nops in places where they really need to be a nop.  (Before inline
marks, we used them just before deferreturn calls, so they could
clobber any caller-saved values.)

Change-Id: I433d1ec455aa37dab8fef6eb7d407f3737dbb97f
Reviewed-on: https://go-review.googlesource.com/c/158057
Reviewed-by: Ilya Tocar <ilya.tocar@intel.com>
src/cmd/compile/internal/amd64/ggen.go
src/cmd/compile/internal/x86/ggen.go