]> Cypherpunks repositories - gostls13.git/commit
runtime: never show system goroutines in traceback
authorDmitry Vyukov <dvyukov@google.com>
Sat, 7 Feb 2015 12:31:18 +0000 (15:31 +0300)
committerDmitry Vyukov <dvyukov@google.com>
Wed, 11 Feb 2015 10:39:48 +0000 (10:39 +0000)
commit59495e8dfda0cfc1fa527337b2fed8a8099137dc
treed102f214df99efde953da072c29cc9bf86a98026
parent84e256753744e765e4a31b48e2a641eecd4d01f1
runtime: never show system goroutines in traceback

Fixes #9791

g.issystem flag setup races with other code wherever we set it.
Even if we set both in parent goroutine and in the system goroutine,
it is still possible that some other goroutine crashes
before the flag is set. We could pass issystem flag to newproc1,
but we start all goroutines with go nowadays.

Instead look at g.startpc to distinguish system goroutines (similar to topofstack).

Change-Id: Ia3467968dee27fa07d9fecedd4c2b00928f26645
Reviewed-on: https://go-review.googlesource.com/4113
Reviewed-by: Keith Randall <khr@golang.org>
src/runtime/crash_test.go
src/runtime/heapdump.go
src/runtime/mfinal.go
src/runtime/mgc0.go
src/runtime/proc.go
src/runtime/proc1.go
src/runtime/runtime2.go
src/runtime/time.go
src/runtime/traceback.go