]> Cypherpunks repositories - gostls13.git/commit
runtime: omit breakpoint during terminal panic
authorRuss Cox <rsc@golang.org>
Wed, 23 Feb 2011 20:42:13 +0000 (15:42 -0500)
committerRuss Cox <rsc@golang.org>
Wed, 23 Feb 2011 20:42:13 +0000 (15:42 -0500)
commit59ce067da8d9e7d968e51f31fb532ed2369f205a
treeb75d130f5edf0f96a23f68d7af8e131833f70d69
parente0a2c5d4b540934e06867710fe7137661a2a39ec
runtime: omit breakpoint during terminal panic

A terminal panic (one that prints a stack trace and exits)
has been calling runtime.breakpoint before calling exit,
so that if running under a debugger, the debugger can
take control.  When not running under a debugger, though,
this causes an additional SIGTRAP on Unix and pop-up
dialogs on Windows.

Support for debugging Go programs has gotten good
enough that we can rely on the debugger to set its own
breakpoint on runtime.exit if it wants to look around.

R=r, r2
CC=golang-dev
https://golang.org/cl/4222043
src/pkg/runtime/darwin/386/signal.c
src/pkg/runtime/darwin/amd64/signal.c
src/pkg/runtime/freebsd/386/signal.c
src/pkg/runtime/freebsd/amd64/signal.c
src/pkg/runtime/linux/386/signal.c
src/pkg/runtime/linux/amd64/signal.c
src/pkg/runtime/windows/386/signal.c