]> Cypherpunks repositories - gostls13.git/commit
cmd/go: rationalize errors in internal/load and internal/modload
authorBryan C. Mills <bcmills@google.com>
Mon, 8 Jul 2019 22:13:23 +0000 (18:13 -0400)
committerBryan C. Mills <bcmills@google.com>
Fri, 28 Feb 2020 19:09:53 +0000 (19:09 +0000)
commit5a61de3fe160cc8b327ee893cd74c4d0ce9dc13d
tree3dbf0328ac9de682fd44c47cd28b600a2cacbc84
parentd11e1f92fc578c5d2e604acfe9ea60d7afb84a0c
cmd/go: rationalize errors in internal/load and internal/modload

This change is a non-minimal fix for #32917, but incidentally fixes
several other bugs and makes the error messages much more ergonomic.

Updates #32917
Updates #27122
Updates #28459
Updates #29280
Updates #30590
Updates #37214
Updates #36173
Updates #36587
Fixes #36008
Fixes #30992

Change-Id: Iedb26d2e0963697c130df5d0f72e7f83ec2dcf06
Reviewed-on: https://go-review.googlesource.com/c/go/+/185345
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
25 files changed:
src/cmd/go/internal/clean/clean.go
src/cmd/go/internal/fmtcmd/fmt.go
src/cmd/go/internal/list/list.go
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/modload/import.go
src/cmd/go/internal/modload/load.go
src/cmd/go/internal/modload/query.go
src/cmd/go/testdata/script/cmd_import_error.txt
src/cmd/go/testdata/script/import_cycle.txt [new file with mode: 0644]
src/cmd/go/testdata/script/list_ambiguous_path.txt
src/cmd/go/testdata/script/list_gofile_in_goroot.txt
src/cmd/go/testdata/script/list_test_non_go_files.txt
src/cmd/go/testdata/script/mod_ambiguous_import.txt
src/cmd/go/testdata/script/mod_dot.txt
src/cmd/go/testdata/script/mod_empty_err.txt
src/cmd/go/testdata/script/mod_fs_patterns.txt
src/cmd/go/testdata/script/mod_goroot_errors.txt
src/cmd/go/testdata/script/mod_import_cycle.txt [new file with mode: 0644]
src/cmd/go/testdata/script/mod_list_dir.txt
src/cmd/go/testdata/script/mod_list_replace_dir.txt
src/cmd/go/testdata/script/mod_readonly.txt
src/cmd/go/testdata/script/mod_replace_import.txt
src/cmd/go/testdata/script/noncanonical_import.txt
src/cmd/go/testdata/script/test_flags.txt
src/cmd/go/testdata/script/vet_internal.txt [new file with mode: 0644]