]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: make TestBlockMutexProfileInlineExpansion stricter
authorNick Ripley <nick.ripley@datadoghq.com>
Tue, 1 Oct 2024 17:51:09 +0000 (13:51 -0400)
committerMichael Pratt <mpratt@google.com>
Wed, 2 Oct 2024 19:57:33 +0000 (19:57 +0000)
commit5b0f8596b766afae9dd1f117a4a5dcfbbf1b80f1
treec3fb13c63c888b4a95acb6c7325439d5c636dc4b
parent268eaf9acbbef7555db02bd3f15bdad9a47d13fa
runtime/pprof: make TestBlockMutexProfileInlineExpansion stricter

While working on CL 611241 and CL 616375, I introduced a bug that wasn't
caught by any test. CL 611241 added more inline expansion at sample time
for block/mutex profile stacks collected via frame pointer unwinding.
CL 616375 then changed how inline expansion for those stacks is done at
reporting time. So some frames passed through multiple rounds of inline
expansion, and this lead to duplicate stack frames in some cases. The
stacks from TestBlockMutexProfileInlineExpansion looked like

sync.(*Mutex).Unlock
runtime/pprof.inlineF
runtime/pprof.inlineE
runtime/pprof.inlineD
runtime/pprof.inlineD
runtime.goexit

after those two CLs, and in particular after CL 616375. Note the extra
inlineD frame. The test didn't catch that since it was only looking for
a few frames in the stacks rather than checking the entire stacks.

This CL makes that test stricter by checking the entire expected stacks
rather than just a portion of the stacks.

Change-Id: I0acc739d826586e9a63a081bb98ef512d72cdc9a
Reviewed-on: https://go-review.googlesource.com/c/go/+/617235
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/pprof/pprof_test.go