]> Cypherpunks repositories - gostls13.git/commit
net: don't reject domain names with only numbers and hyphens
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 24 Sep 2018 17:30:48 +0000 (17:30 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 24 Sep 2018 17:56:44 +0000 (17:56 +0000)
commit5b3aafe2b51b5455a42a65cca1cf0e8393970c03
treee0d6014b4fd01f9d4c68dbe37ce70aa9f7622318
parent4039be00a9e77bd4080ac657a940472341fa088f
net: don't reject domain names with only numbers and hyphens

From https://github.com/golang/go/issues/17659#issuecomment-423113606 ...

> In kubernetes , isDomainName reject Pods "A Record" "pod-ip-address",
> for example: "172-17-0-16", as RFC 3696 section 2 requires
> "top-level domain names not be all-numeric", but this example has
> three hyphen, so I think it should not be reject.

Updates #17659

Change-Id: Ibd8ffb9473d69c45c91525953c09c6749233ca20
Reviewed-on: https://go-review.googlesource.com/136900
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Gudger <igudger@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/dnsclient.go
src/net/dnsname_test.go