]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: update GREASE-Server-TLS13 BoGo skip
authorDaniel McCarney <daniel@binaryparadox.net>
Wed, 19 Feb 2025 18:10:36 +0000 (13:10 -0500)
committerDaniel McCarney <daniel@binaryparadox.net>
Mon, 10 Mar 2025 21:20:22 +0000 (14:20 -0700)
commit5b4209fedb10086e845cabdb02d2990a6090841b
treeac0e1b8f484d23a6e27767a8348a79f350425aa6
parent01688daca63c3775f07f908268af99bd3d3c9386
crypto/tls: update GREASE-Server-TLS13 BoGo skip

Previously this test was skipped without a comment clarifying why. In
practice it's because crypto/tls doesn't generate GREASE extensions at
this time, and the test expects to find one in the NewSessionTicket
message extensions produced by a server.

We're already skipping some other GREASE related test as
not-yet-implemented without explicit bogo_config.json exclusion by way
of the -enable-grease flag not being implemented, however for TLS
1.3 servers the BoGo expectation is that they _always_ send GREASE, and
so the -enable-grease flag isn't provided and an explicit skip must be
used.

We should revisit this alongside implementing GREASE ext production in
general for both clients and servers.

Updates #72006

Change-Id: I8af4b555ac8c32cad42215fbf26aa0feae90fa21
Reviewed-on: https://go-review.googlesource.com/c/go/+/650717
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
src/crypto/tls/bogo_config.json