]> Cypherpunks repositories - gostls13.git/commit
misc/cgo/testshared: explicitly set GOBIN (instead of unsetting it)
authorBryan C. Mills <bcmills@google.com>
Mon, 24 Feb 2020 18:58:29 +0000 (13:58 -0500)
committerBryan C. Mills <bcmills@google.com>
Mon, 24 Feb 2020 20:47:43 +0000 (20:47 +0000)
commit5c7dbf40e1e0af9d8fc4521e1ce7bd0afaa1f2c4
treee4f5d096ae57dba47de203575ca3a92c07d7b499
parentbc98e35b536785a2931f805458a0ff763c4b4b5e
misc/cgo/testshared: explicitly set GOBIN (instead of unsetting it)

If GOBIN is set in the GOENV file, then merely unsetting it in the
process environment is not sufficient. We can instead either set GOBIN
explicitly, or disable GOENV explicitly. For now, we (semi-arbitrary)
choose the former.

Fixes #37390

Change-Id: Iec54532c804b70546d695105cd89e9169eac5dbb
Reviewed-on: https://go-review.googlesource.com/c/go/+/220652
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
misc/cgo/testshared/shared_test.go