]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: handle go.mod error msg reference in noder, not type checker
authorRobert Griesemer <gri@golang.org>
Thu, 22 Sep 2022 01:38:23 +0000 (18:38 -0700)
committerGopher Robot <gobot@golang.org>
Fri, 23 Sep 2022 20:27:07 +0000 (20:27 +0000)
commit5d213a3dc764624e3f01d7e957fedc63bfdcfa0f
tree8aa41167a993105eb5538ea3782a98043fa8c3aa
parent2f3008386fbfbc62544e3799d14db40cbe703218
cmd/compile: handle go.mod error msg reference in noder, not type checker

Currently, for version errors, types2 adds the helpful hint

(-lang was set to go1.xx; check go.mod)

where 1.xx is the respective language version, to the error message.
This requires that the type checker knows that it was invoked by the
compiler, which is done through the Config.CompilerErrorMessages flag.

This change looks for version errors being returned by the type checker
and then adds the hint at that point, external to the type checker.
This removes a dependency on the Config.CompilerErrorMessages. Once
we have removed all dependencies on Config.CompilerErrorMessages we
can remove it.

For #55326.

Change-Id: I1f9b2e472c49fe785a2075e26c4b3d9b8fcdbf4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/432559
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/noder/irgen.go
src/cmd/compile/internal/types2/conversions.go
src/cmd/compile/internal/types2/errors.go
src/go/types/conversions.go
src/go/types/errors.go