]> Cypherpunks repositories - gostls13.git/commit
runtime: explain and enforce that _panic values live on the stack
authorAustin Clements <austin@google.com>
Thu, 8 Mar 2018 22:48:22 +0000 (17:48 -0500)
committerAustin Clements <austin@google.com>
Thu, 8 Mar 2018 23:35:46 +0000 (23:35 +0000)
commit5d22cebb1272b3761860c5fa9ee82ceb3d94c628
tree208665ac819367aaaf61c8b4d658e93727ad385c
parent60a9e5d613d6de21735e54ca62246e3f8ef8c8d3
runtime: explain and enforce that _panic values live on the stack

It's a bit mysterious that _defer.sp is a uintptr that gets
stack-adjusted explicitly while _panic.argp is an unsafe.Pointer that
doesn't, but turns out to be critically important when a deferred
function grows the stack before doing a recover.

Add a comment explaining that this works because _panic values live on
the stack. Enforce this by marking _panic go:notinheap.

Change-Id: I9ca49e84ee1f86d881552c55dccd0662b530836b
Reviewed-on: https://go-review.googlesource.com/99735
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/runtime/runtime2.go