]> Cypherpunks repositories - gostls13.git/commit
net: skip test affected by local network config on non-builder
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Sun, 26 Feb 2023 12:41:32 +0000 (19:41 +0700)
committerGopher Robot <gobot@golang.org>
Mon, 27 Feb 2023 11:55:26 +0000 (11:55 +0000)
commit5dc379e2de79dbfc207bb9d6d44ad5a8c546f14a
treea09d3b6d48c84f2eb84ba2e67349e16be01d76f8
parent31881f87873b84709a49ca17195bbe5b3f683acf
net: skip test affected by local network config on non-builder

CL 461275 uses testing.Short to skip this kind of tests. But it may lead
to false positive, because testing.Short may not always set. For
example, the normal workflow when testing changes in net package is
running:

go test -v net

in local machine, that will cause the test failed.

Using testenv.Builder is better, since when it's the standard way to
check whether the test is running on builder or local machine.

Change-Id: Ia5347eb76b4f0415dde8fa3d6c89bd0105f15aa7
Reviewed-on: https://go-review.googlesource.com/c/go/+/471437
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/net/dnsclient_unix_test.go