]> Cypherpunks repositories - gostls13.git/commit
cmd/vet: add vet runner script for core
authorJosh Bleecher Snyder <josharian@gmail.com>
Sat, 9 Jul 2016 22:29:32 +0000 (15:29 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Sat, 10 Sep 2016 21:56:34 +0000 (21:56 +0000)
commit5de2e5b73e79aea02463d661ec87cee4e944990b
treea61a909834bd68be0d84c9226c3163ef8e35a057
parent4cf95fda64d76ca044319fd0a292ad3a77c1da0b
cmd/vet: add vet runner script for core

This CL adds a script to run vet on std and cmd.

There are a considerable number of false positives,
mostly from legitimate but unusual assembly in
the runtime and reflect packages.

There are also a few false positives that need fixes.
They are noted as such in the whitelists;
they're not worth holding this CL for.

The unsafe pointer check is disabled.
The false positive rate is just too high to be worth it.

There is no cmd/dist/test integration yet.
The tentative plan is that we'll check the local platform
during all.bash, and that there'll be a fast builder that
checks all platforms (to cover platforms that can't exec).

Fixes #11041

Change-Id: Iee4ed32b05447888368ed86088e3ed3771f84442
Reviewed-on: https://go-review.googlesource.com/27811
Reviewed-by: Rob Pike <r@golang.org>
42 files changed:
src/cmd/vet/all/main.go [new file with mode: 0644]
src/cmd/vet/all/whitelist/386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/64bit.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/all.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/android_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/android_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/android_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/arm64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/darwin_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/darwin_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/darwin_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/darwin_arm64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/dragonfly_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/freebsd_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/freebsd_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/freebsd_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/linux_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/linux_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/linux_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/linux_arm64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/linux_ppc64x.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/mips64x.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/nacl_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/nacl_amd64p32.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/nacl_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/netbsd.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/netbsd_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/netbsd_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/netbsd_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/openbsd_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/openbsd_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/openbsd_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/plan9_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/plan9_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/plan9_arm.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/ppc64x.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/solaris_amd64.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/windows.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/windows_386.txt [new file with mode: 0644]
src/cmd/vet/all/whitelist/windows_amd64.txt [new file with mode: 0644]