]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] cmd/link: force eager binding when using plugins on darwin
authorCherry Mui <cherryyz@google.com>
Thu, 16 Dec 2021 19:33:13 +0000 (14:33 -0500)
committerCherry Mui <cherryyz@google.com>
Mon, 7 Feb 2022 20:38:28 +0000 (20:38 +0000)
commit5ef95666946dd744c0392166981783f72687993f
tree5063be892fd59aefbe0b8194248e9c21df318ccd
parent6b3e741a834c34b8a844a33b3aa060dd4ed37231
[release-branch.go1.16] cmd/link: force eager binding when using plugins on darwin

When building/using plugins on darwin, we need to use flat
namespace so the same symbol from the main executable and the
plugin can be resolved to the same address. Apparently, when using
flat namespace the dynamic linker can hang at forkExec when
resolving a lazy binding. Work around it by forcing early bindings.

Updates #38824.
Fixes #50245.

Change-Id: I983aa0a0960b15bf3f7871382e8231ee244655f4
Reviewed-on: https://go-review.googlesource.com/c/go/+/372798
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit c5fee935bbb8f02406eb653cfed550593755a1a4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/373095
misc/cgo/testplugin/plugin_test.go
misc/cgo/testplugin/testdata/forkexec/main.go [new file with mode: 0644]
src/cmd/link/internal/ld/lib.go