]> Cypherpunks repositories - gostls13.git/commit
cmd/trace: merge testdata debugging tools into the trace tool
authorMichael Anthony Knyszek <mknyszek@google.com>
Fri, 21 Jun 2024 15:32:29 +0000 (15:32 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 23 Jul 2024 14:57:42 +0000 (14:57 +0000)
commit5f073d361f96e38bd31cf9274769bd4d0f5e0a5a
treedb641bf4ea360a650911c92e256eb4690607f5b1
parentb8f83e22703ee23d49d95154449ce7066402d5c9
cmd/trace: merge testdata debugging tools into the trace tool

Currently internal/trace/testdata contains three debugging tools which
were written early in the trace rewrite for debugging. Two of these are
completely redundant with go tool trace -d=1 and go tool trace -d=2. The
only remaining one landed in the last cycle and could easily also be
another debug mode.

This change thus merges gotraceeventstats into go tool trace as a new
debug mode, and updates the debug mode flag (-d) to accept a string,
giving each mode a more descriptive name.

Change-Id: I170f30440691b81de846b4e247deb3d0982fc205
Reviewed-on: https://go-review.googlesource.com/c/go/+/593975
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
src/cmd/trace/main.go
src/internal/trace/raw/event.go
src/internal/trace/testdata/cmd/gotraceeventstats/main.go [deleted file]
src/internal/trace/testdata/cmd/gotraceraw/main.go [deleted file]
src/internal/trace/testdata/cmd/gotracevalidate/main.go [deleted file]