]> Cypherpunks repositories - gostls13.git/commit
go/types: avoid importer.Default
authorAlan Donovan <adonovan@google.com>
Wed, 22 Jan 2025 15:43:44 +0000 (10:43 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 22 Jan 2025 18:13:04 +0000 (10:13 -0800)
commit608acff8479640b00c85371d91280b64f5ec9594
tree4f0c59ce64507f72515e89764524328fcbe69981
parent9d21ef3bd43acedfe5317184e63cc6b3dd19cbdf
go/types: avoid importer.Default

It uses a throwaway FileSet, so all position info is
wrong, and potentially misleading.

(Various other helpers in go/types testing also use a
throwaway FileSet, and should really accept it as a parameter.)

Fixes #71272

Change-Id: I9d899b987837b4041a299aad5ec266cb4f5d125c
Reviewed-on: https://go-review.googlesource.com/c/go/+/643777
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
src/go/types/api_test.go
src/go/types/check_test.go
src/go/types/eval_test.go
src/go/types/example_test.go
src/go/types/issues_test.go
src/go/types/lookup_test.go
src/go/types/mono_test.go
src/go/types/resolver_test.go
src/go/types/self_test.go
src/go/types/sizes_test.go