]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/syntax: fix error handling for Read/Parse calls
authorRobert Griesemer <gri@golang.org>
Wed, 9 Nov 2016 00:01:56 +0000 (16:01 -0800)
committerRobert Griesemer <gri@golang.org>
Wed, 9 Nov 2016 17:48:40 +0000 (17:48 +0000)
commit60a9bf9f957d48856839873c6dcb699afe7da359
tree019a1a18499cc6238a505c845129977db25873d6
parentad020477f4dfe731450b6dd3dd15ea43aab0d0f1
cmd/compile/internal/syntax: fix error handling for Read/Parse calls

- define syntax.Error for cleaner error reporting
- abort parsing after first error if no error handler is installed
- make sure to always report the first error, if any
- document behavior of API calls
- while at it: rename ReadXXX -> ParseXXX (clearer)
- adjust cmd/compile noder.go accordingly

Fixes #17774.

Change-Id: I7893eedea454a64acd753e32f7a8bf811ddbb03c
Reviewed-on: https://go-review.googlesource.com/32950
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/noder.go
src/cmd/compile/internal/syntax/dumper_test.go
src/cmd/compile/internal/syntax/parser.go
src/cmd/compile/internal/syntax/parser_test.go
src/cmd/compile/internal/syntax/printer_test.go
src/cmd/compile/internal/syntax/scanner_test.go
src/cmd/compile/internal/syntax/source.go
src/cmd/compile/internal/syntax/syntax.go