]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/link: fix bugs in setArchSyms
authorThan McIntosh <thanm@google.com>
Sun, 5 Apr 2020 16:40:20 +0000 (12:40 -0400)
committerThan McIntosh <thanm@google.com>
Tue, 7 Apr 2020 17:17:30 +0000 (17:17 +0000)
commit60baf83a820785f26bc61521db8e931165accc24
tree29878add4fdf5bbad1398cdfa804ed382ce48fea
parent587faf67d7e62c4f844cd2d1a8af3dd6ea7c3555
[dev.link] cmd/link: fix bugs in setArchSyms

The code in setArchsyms that sets up TOC symbols was buggy; it was
kicking in only for aix-ppc64 and not linux-ppc64. These symbols are
required for both ABIs, so change the guard in question from
"ctx.IsAIX()" to "ctxt.IsPPC64()". Also, the code to create versioned
".TOC." syms was not passing the correct symbol version to the loader
(now fixed).

Change-Id: I356071e528beadad20f61d067059eaf26f06e06b
Reviewed-on: https://go-review.googlesource.com/c/go/+/227257
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/link/internal/ld/lib.go