]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: don't generate panicshift for masked int shifts
authorJosh Bleecher Snyder <josharian@gmail.com>
Wed, 13 Mar 2019 20:53:38 +0000 (13:53 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Thu, 14 Mar 2019 00:03:29 +0000 (00:03 +0000)
commit61945fc5022e36ae88758f2c4e8f7c29f0824ae0
treee938876dd83eae7b00ae424ad44d3b9f3b817c34
parent2d21bf4252781e3997c30a873e56325436ca3f76
cmd/compile: don't generate panicshift for masked int shifts

We know that a & 31 is non-negative for all a, signed or not.
We can avoid checking that and needing to write out an
unreachable call to panicshift.

Change-Id: I32f32fb2c950d2b2b35ac5c0e99b7b2dbd47f917
Reviewed-on: https://go-review.googlesource.com/c/go/+/167499
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/gen/generic.rules
src/cmd/compile/internal/ssa/rewritegeneric.go
test/codegen/shift.go