]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: schedule values with no in-block uses later
authorKeith Randall <khr@golang.org>
Wed, 1 Feb 2023 16:31:03 +0000 (08:31 -0800)
committerKeith Randall <khr@google.com>
Wed, 1 Feb 2023 18:41:07 +0000 (18:41 +0000)
commit6224db9b4d6acbc04a357ef0505424d74b723233
treefa456088252e8e96f1e03ab68d5b2ba42cb40fb7
parentc846964df5eeab05c8620d34fcd3e56d5b6cbcfa
cmd/compile: schedule values with no in-block uses later

When scheduling a block, deprioritize values whose results aren't used
until subsequent blocks.

For #58166, this has the effect of pushing the induction variable increment
to the end of the block, past all the other uses of the pre-incremented value.

Do this only with optimizations on. Debuggers have a preference for values
in source code order, which this CL can degrade.

Fixes #58166
Fixes #57976

Change-Id: I40d5885c661b142443c6d4702294c8abe8026c4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/463751
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/compile/internal/ssa/schedule.go
test/codegen/issue58166.go [new file with mode: 0644]