]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: decrease inlining call cost from 60 to 57
authorDavid Chase <drchase@google.com>
Fri, 30 Nov 2018 13:36:00 +0000 (08:36 -0500)
committerDavid Chase <drchase@google.com>
Sat, 1 Dec 2018 15:03:28 +0000 (15:03 +0000)
commit624e197c71b673f0b3ebc57f774536131b4f0f26
tree0cf5b914d1a08ff5de53c1a9b5ed86b97d0407dc
parentf70bd914353b2331a48eedb84aceb458982eaac0
cmd/compile: decrease inlining call cost from 60 to 57

A Go user made a well-documented request for a slightly
lower threshold.  I tested against a selection of other
people's benchmarks, and saw a tiny benefit (possibly noise)
at equally tiny cost, and no unpleasant surprises observed
in benchmarking.

I.e., might help, doesn't hurt, low risk, request was
delivered on a silver platter.

It did, however, change the behavior of one test because
now bytes.Buffer.Grow is eligible for inlining.

Updates #19348.

Change-Id: I85e3088a4911290872b8c6bda9601b5354c48695
Reviewed-on: https://go-review.googlesource.com/c/151977
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/gc/inl.go
test/fixedbugs/issue7921.go