]> Cypherpunks repositories - gostls13.git/commit
database/sql: buffers provided to Rows.Next should not be modified by drivers
authorDaniel Theophanes <kardianos@gmail.com>
Thu, 25 Jan 2018 18:50:02 +0000 (10:50 -0800)
committerDaniel Theophanes <kardianos@gmail.com>
Thu, 25 Jan 2018 19:14:14 +0000 (19:14 +0000)
commit651ddbdb5056ded455f47f9c494c67b389622a47
tree5dba249d72c82a175e85ea71b95824348566c70f
parent7350297eb61e71c901504d132b1d9077a11f57f6
database/sql: buffers provided to Rows.Next should not be modified by drivers

Previously we allowed drivers to modify the row buffer used to scan
values when closing Rows. This is no longer acceptable and can lead
to data races.

Fixes #23519

Change-Id: I91820a6266ffe52f95f40bb47307d375727715af
Reviewed-on: https://go-review.googlesource.com/89936
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
doc/go1.10.html
src/database/sql/driver/driver.go
src/database/sql/fakedb_test.go
src/database/sql/sql_test.go