]> Cypherpunks repositories - gostls13.git/commit
text/template: perform value validity checks
authorNodir Turakulov <nodir@google.com>
Sun, 6 Sep 2015 06:16:49 +0000 (23:16 -0700)
committerRob Pike <r@golang.org>
Wed, 9 Sep 2015 23:25:44 +0000 (23:25 +0000)
commit6599450016244b9e3e074e87d7064219ee2e5cf8
treeaa84a8f7790fe645868195cb1d259fd6a4ec6bbc
parent00c638d243056b24f1deeb2d1d954e62baedd468
text/template: perform value validity checks

Check reflect.Value.IsValid() before calling other reflect.Value methods
that panic on zero values.

Added tests for cases with untyped nils. They panicked without these fixes.

Removed a TODO.

Fixes #12356

Change-Id: I9b5cbed26db09a0a7c36d99a93f8b9729899d51e
Reviewed-on: https://go-review.googlesource.com/14340
Reviewed-by: Rob Pike <r@golang.org>
src/text/template/exec.go
src/text/template/exec_test.go
src/text/template/funcs.go