]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] runtime: scavenge on growth instead of inline with allocation
authorMichael Anthony Knyszek <mknyszek@google.com>
Tue, 25 Jun 2019 19:06:57 +0000 (19:06 +0000)
committerAndrew Bonventre <andybons@golang.org>
Fri, 4 Oct 2019 17:11:45 +0000 (17:11 +0000)
commit66b8787f6bb461838dbf482d021c30daeef6dfa6
tree7193e9a8cb4fb7c2acfc51108241d8f0611f3a48
parentcd951aeec4e658b3a1f05362c9655791427d6de6
[release-branch.go1.13] runtime: scavenge on growth instead of inline with allocation

Inline scavenging causes significant performance regressions in tail
latency for k8s and has relatively little benefit for RSS footprint.

We disabled inline scavenging in Go 1.12.5 (CL 174102) as well, but
we thought other changes in Go 1.13 had mitigated the issues with
inline scavenging. Apparently we were wrong.

This CL switches back to only doing foreground scavenging on heap
growth, rather than doing it when allocation tries to allocate from
scavenged space.

Fixes #34556

Change-Id: I1f5df44046091f0b4f89fec73c2cde98bf9448cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/183857
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit eb96f8a57444d174bba500b3a5d2a8b21b7e6d1e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198486
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
src/runtime/mheap.go