]> Cypherpunks repositories - gostls13.git/commit
cmd/doc: don't print package clauses on error
authorRob Pike <r@golang.org>
Fri, 3 Apr 2020 02:57:01 +0000 (13:57 +1100)
committerRob Pike <r@golang.org>
Fri, 17 Apr 2020 21:42:13 +0000 (21:42 +0000)
commit670cb9c37769f07fd8c2aac6270a9f2342d2b970
tree7247f5ebf329a9bb1661024c65f40d82a51d4bf3
parent9b56d3e536839f5b1b55d0451e25adc58694dda7
cmd/doc: don't print package clauses on error

Everybody was deferring a flush when main already
did that, so drop all that nonsense. (Flush was doing
the package clause stuff.) But then make sure we do
get a package clause when there is correctly no output,
as for an empty package. Do that by triggering a
package clause in allDoc and packageDoc.

Slightly tricky but way less intricate than before.

Fixes #37969.

Change-Id: Ia86828436e6c4ab46e6fdaf2c550047f37f353f3
Reviewed-on: https://go-review.googlesource.com/c/go/+/226998
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/doc/doc_test.go
src/cmd/doc/pkg.go