]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: improve undo of poset
authorGiovanni Bajo <rasky@develer.com>
Sat, 12 May 2018 20:13:44 +0000 (22:13 +0200)
committerDavid Chase <drchase@google.com>
Mon, 14 May 2018 14:31:48 +0000 (14:31 +0000)
commit67656ba71b54779d9f98995a12ed87e7c7618cad
tree96d966243ec28054911c136e146b352b9ed77069
parent7bac2a95f65418ec18d1fb5f30ae47e91980f30c
cmd/compile: improve undo of poset

prove uses the poset datastructure in a DFS walk, and always undoes
it back to its pristine status. Before this CL, poset's undo of
a new node creation didn't fully deallocate the node, which means
that at the end of prove there was still some allocated memory pending.

This was not a problem until now because the posets used by prove
were discarded after each function, but it would prevent recycling
them between functions (as a followup CL does).

Change-Id: I1c1c99c03fe19ad765395a43958cb256f686765a
Reviewed-on: https://go-review.googlesource.com/112976
Run-TryBot: Giovanni Bajo <rasky@develer.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/fmt_test.go
src/cmd/compile/internal/ssa/poset.go
src/cmd/compile/internal/ssa/poset_test.go