]> Cypherpunks repositories - gostls13.git/commit
debug/pe: introduce File.COFFSymbols and (*COFFSymbol).FullName
authorAlex Brainman <alex.brainman@gmail.com>
Thu, 21 Apr 2016 06:51:36 +0000 (16:51 +1000)
committerAlex Brainman <alex.brainman@gmail.com>
Sun, 24 Apr 2016 01:37:03 +0000 (01:37 +0000)
commit687fe991e42f15fe1f491680c615ef96568f780a
tree2726344a1a64c932c0f43b28bee1d39bd871470a
parentd224e98d9ac969e733f5578dce3e1831c5c84f45
debug/pe: introduce File.COFFSymbols and (*COFFSymbol).FullName

Reloc.SymbolTableIndex is an index into symbol table. But
Reloc.SymbolTableIndex cannot be used as index into File.Symbols,
because File.Symbols slice has Aux lines removed as it is built.

We cannot change the way File.Symbols works, so I propose we
introduce new File.COFFSymbols that does not have that limitation.

Also unlike File.Symbols, File.COFFSymbols will consist of
COFFSymbol. COFFSymbol matches PE COFF specification exactly,
and it is simpler to use.

Updates #15345

Change-Id: Icbc265853a472529cd6d64a76427b27e5459e373
Reviewed-on: https://go-review.googlesource.com/22336
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/debug/pe/file.go
src/debug/pe/section.go
src/debug/pe/symbol.go