]> Cypherpunks repositories - gostls13.git/commit
cmd/go: only attempt to match subset of $GOCACHE in test
authorMichael Pratt <mpratt@google.com>
Thu, 18 Apr 2024 17:52:44 +0000 (13:52 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 18 Apr 2024 18:28:25 +0000 (18:28 +0000)
commit68c0ad3a689833344fada8acc1f36a06c343caa4
tree95789de07f9660c944923157de87bc588976e5f4
parentad87d4404782d816f7a4497113b6b983b45aa442
cmd/go: only attempt to match subset of $GOCACHE in test

This test attempted to be clever by looking for the entirety of $GOCACHE
in the compile command line to ensure that the profile was coming from
cache.

Unfortunately, on Windows $GOCACHE contains \, which needs extra
escaping in a regexp. As an approximate alternative, just look for the
"gocache" component specified when defining GOCACHE.

This fixes the Windows longtest builders.

Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest
Change-Id: If6c77cf066d8612431e0720405254e1fdf528e9b
Reviewed-on: https://go-review.googlesource.com/c/go/+/580137
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Bypass: Michael Pratt <mpratt@google.com>
src/cmd/go/testdata/script/build_cache_pgo.txt