]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.10] cmd/go: restrict meta imports to valid schemes
authorIan Lance Taylor <iant@golang.org>
Thu, 15 Feb 2018 23:57:13 +0000 (15:57 -0800)
committerAndrew Bonventre <andybons@golang.org>
Thu, 29 Mar 2018 06:06:56 +0000 (06:06 +0000)
commit6936a87ce1db9fab4b1b413a24a662bf66331995
treea8c4306090fd335ab782f05c11f307b0e3f861b3
parent678dede7bc22a7cccfe78c42711478a9b1ecf4d3
[release-branch.go1.10] cmd/go: restrict meta imports to valid schemes

Before this change, when using -insecure, we permitted any meta import
repo root as long as it contained "://". When not using -insecure, we
restrict meta import repo roots to be valid URLs. People may depend on
that somehow, so permit meta import repo roots to be invalid URLs, but
require them to have valid schemes per RFC 3986.

Fixes #23867

Change-Id: Iac666dfc75ac321bf8639dda5b0dba7c8840922d
Reviewed-on: https://go-review.googlesource.com/94603
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/102778
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/go/internal/get/vcs.go
src/cmd/go/internal/get/vcs_test.go