]> Cypherpunks repositories - gostls13.git/commit
[dev.cc] all: edit assembly source for ARM to be more regular
authorRob Pike <r@golang.org>
Fri, 13 Feb 2015 22:21:18 +0000 (14:21 -0800)
committerRob Pike <r@golang.org>
Fri, 13 Feb 2015 23:08:51 +0000 (23:08 +0000)
commit69ddb7a40849f9330170144dc82a1da9627acaa9
treee3e1950619dcc845d114d5edbe81cdceb62b7110
parent2ecefd41fa853e40346e0f89c632efb8682c431b
[dev.cc] all: edit assembly source for ARM to be more regular

Several .s files for ARM had several properties the new assembler will not support.
These include:

- mentioning SP or PC as a hardware register
These are always pseudo-registers except that in some contexts
they're not, and it's confusing because the context should not affect
which register you mean. Change the references to the hardware
registers to be explicit: R13 for SP, R15 for PC.
- constant creation using assignment
The files say a=b when they could instead say #define a b.
There is no reason to have both mechanisms.
- R(0) to refer to R0.
Some macros use this to a great extent. Again, it's easy just to
use a #define to rename a register.

Change-Id: I002335ace8e876c5b63c71c2560533eb835346d2
Reviewed-on: https://go-review.googlesource.com/4822
Reviewed-by: Dave Cheney <dave@cheney.net>
src/crypto/md5/md5block_arm.s
src/crypto/rc4/rc4_arm.s
src/crypto/sha1/sha1block_arm.s
src/runtime/asm_arm.s
src/runtime/memclr_arm.s
src/runtime/memmove_arm.s
src/runtime/rt0_linux_arm.s
src/runtime/sys_linux_arm.s
src/runtime/vlop_arm.s
src/sync/atomic/asm_linux_arm.s