]> Cypherpunks repositories - gostls13.git/commit
runtime: properly frame panic values in tracebacks
authorAlan Donovan <adonovan@google.com>
Tue, 23 Apr 2024 16:44:54 +0000 (12:44 -0400)
committerGopher Robot <gobot@golang.org>
Wed, 8 May 2024 19:10:41 +0000 (19:10 +0000)
commit69e75c8581e15328454bb6e2f1dc347f73616b37
treef0fabe495e978fb211ef909e4c4b8d8a4085d559
parent4513f1a1c1037574bfd94b8637329246f475a534
runtime: properly frame panic values in tracebacks

This CL causes the printing of panic values to ensure that all
newlines in the output are immediately followed by a tab, so
that there is no way for a maliciously crafted panic value to
fool a program attempting to parse the traceback into thinking
that the panic value is in fact a goroutine stack.

See https://github.com/golang/go/issues/64590#issuecomment-1932675696

+ release note

Updates #64590
Updates #63455

Change-Id: I5142acb777383c0c122779d984e73879567dc627
Reviewed-on: https://go-review.googlesource.com/c/go/+/581215
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
doc/next/4-runtime.md
src/runtime/crash_test.go
src/runtime/error.go
src/runtime/panic.go
src/runtime/panic_test.go
src/runtime/testdata/testprog/crash.go
src/runtime/testdata/testprog/panicprint.go
src/testing/testing_test.go