]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix stenciling of conversions between interfaces
authorKeith Randall <khr@golang.org>
Tue, 24 Aug 2021 22:41:11 +0000 (15:41 -0700)
committerKeith Randall <khr@golang.org>
Fri, 27 Aug 2021 16:41:29 +0000 (16:41 +0000)
commit6a35e075126f4f78d50f236856fc5ba759616ee7
treea4dd973e889cbb3b02bb8c507f5a3e0ffaae2354
parent4f0dedca7141afafbc01be96097570de2da2bdcc
cmd/compile: fix stenciling of conversions between interfaces

Conversions need to allow nil through.
We do that using a CONVIFACE instead of a DOTTYPE.

Also reorganize how nonempty interfaces are handled.
For nonempty to empty, a simple CONVIFACE suffices.
For nonempty to nonempty, we need to call the runtime to get the
new itab. Use the entry from the dictionary to identify the
target interface type (if parameterized).

Fixes #47925

Change-Id: I4ffeed964318bb3e270b06f558e6ab9c5bfc7188
Reviewed-on: https://go-review.googlesource.com/c/go/+/344830
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
src/cmd/compile/internal/noder/stencil.go
test/typeparam/eface.go
test/typeparam/issue47925.go [new file with mode: 0644]
test/typeparam/issue47925b.go [new file with mode: 0644]
test/typeparam/issue47925c.go [new file with mode: 0644]
test/typeparam/issue47925d.go [new file with mode: 0644]