]> Cypherpunks repositories - gostls13.git/commit
cmd/go: do not confuse files for standard library packages
authorRuss Cox <rsc@golang.org>
Fri, 13 Jan 2023 15:21:56 +0000 (10:21 -0500)
committerGopher Robot <gobot@golang.org>
Tue, 17 Jan 2023 22:30:23 +0000 (22:30 +0000)
commit6bb003d0323648d5f11689dab40ba4b158d7d6b4
tree0608a999712afa34bf1e02df7fa417a02e6dee10
parentf773bef9ab837db1bd81df375a701196b23ac510
cmd/go: do not confuse files for standard library packages

I often create dummy files holding various data named things like 'z'.
If a file (not directory) GOROOT/src/z exists, it confuses cmd/go into
thinking z is a standard library package, which breaks the test
Script/mod_vendor.

This CL fixes internal/goroot to only report that something is a standard
library package when a directory with that name exists, not just a file.

Change-Id: I986c9a425e78d23c7e033aeadb8e9f71aab2b878
Reviewed-on: https://go-review.googlesource.com/c/go/+/461955
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
src/cmd/go/testdata/script/src_file.txt [new file with mode: 0644]
src/internal/goroot/gc.go