]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] os/exec: return clear error for missing cmd.Path
authorRuss Cox <rsc@golang.org>
Tue, 3 May 2022 19:14:56 +0000 (15:14 -0400)
committerAlex Rakoczy <alex@golang.org>
Fri, 27 May 2022 14:57:10 +0000 (14:57 +0000)
commit6c65a4ab8e8bc6caa70d3bfe9b4bdd3dc26b8de5
tree02ed569dd15d1611c85b51cc6c730193ebb000e3
parenta08baaad1a7c8e88b5a521ae12666b0aa3dc252a
[release-branch.go1.18] os/exec: return clear error for missing cmd.Path

Following up on CL 403694, there is a bit of confusion about
when Path is and isn't set, along with now the exported Err field.
Catch the case where Path and Err (and lookPathErr) are all unset
and give a helpful error.

Updates #52574
Followup after #43724.

Fixes #53057
Fixes CVE-2022-30580

Change-Id: I03205172aef3801c3194f5098bdb93290c02b1b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/403759
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
(cherry picked from commit 960ffa98ce73ef2c2060c84c7ac28d37a83f345e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408577
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
src/os/exec/exec.go
src/os/exec/exec_test.go