]> Cypherpunks repositories - gostls13.git/commit
cmd/go: check that package paths are invariantly non-empty
authorBryan C. Mills <bcmills@google.com>
Tue, 9 Oct 2018 13:50:56 +0000 (09:50 -0400)
committerBryan C. Mills <bcmills@google.com>
Tue, 9 Oct 2018 20:10:02 +0000 (20:10 +0000)
commit6c85693bf14e246e5a53466048329cb7571a674c
treeb41c87562ff68c32a3113103aaab78b25c14ff14
parent48dc42b6afe7ad13102c55b8200c9f4577a88c84
cmd/go: check that package paths are invariantly non-empty

The empty string is never a valid package path.
Passing an empty string to a function that expects a package path
indicates some missing validation step further up the call chain —
typically (and most easily) a missed error check.

Change-Id: I78a2403d95b473bacb0d40814cd9d477ecfd5351
Reviewed-on: https://go-review.googlesource.com/c/140857
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/modload/build.go
src/cmd/go/internal/modload/load.go