]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] testing/race: fixing intermittent test failure
authorDaniel S. Fava <danielsfava@gmail.com>
Fri, 12 Feb 2021 08:54:50 +0000 (09:54 +0100)
committerDmitri Shuralyov <dmitshur@golang.org>
Thu, 27 Jan 2022 16:35:59 +0000 (16:35 +0000)
commit6cbcf581aff555d09d91ae1b3b360511ebb7e35f
treefc9206e972c694cb868870786a3c35bf031fd635
parent57d5d8f98748d0c3f47d44898acaa019c548ffc1
[release-branch.go1.16] testing/race: fixing intermittent test failure

Test NoRaceMutexPureHappensBefore in runtime/race/testdata/mutex_test.go
expects the second spawned goroutine to run after the first.  The test
attempts to force this scheduling with a 10 millisecond wait.  Following
a suggestion by Bryan Mills, we force this scheduling using a shared
variable whose access take place within the existing mutex.

Fixes #50832.
Updates #35745.

Change-Id: Ib23ec51492ecfeed4752e020401dd25755a669ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/291292
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit aaed6cbced238030053df4e54f676a1d59df89d7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381034
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/runtime/race/testdata/mutex_test.go