]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] cmd/compile: simplify inlining variadic calls
authorMatthew Dempsky <mdempsky@google.com>
Wed, 26 May 2021 03:14:33 +0000 (20:14 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Wed, 26 May 2021 23:50:45 +0000 (23:50 +0000)
commit6da1661371410c46af84c578d644052894226314
treee6b755594f507f9e586dabf674006fda69c32efd
parente99e9a6e0147592b12175a19a2a9dafe96a984f9
[dev.typeparams] cmd/compile: simplify inlining variadic calls

We already have and use FixVariadicCall to normalize non-dotted calls
to variadic functions elsewhere in the compiler to simplify rewriting
of function calls. This CL updates inl.go to use it too.

A couple tests need to be updated to (correctly) expect diagnostics
about "... argument" instead of a slice literal. This is because
inl.go previously failed to set Implicit on the slice literal node.

Change-Id: I76bd79b95ae1f16e3b26ff7e9e1c468f538fd1f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/323009
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
src/cmd/compile/internal/inline/inl.go
src/cmd/compile/internal/typecheck/func.go
src/cmd/compile/internal/walk/convert.go
test/fixedbugs/issue30898.go
test/inline_variadic.go