]> Cypherpunks repositories - gostls13.git/commit
cmd/go: make "finding" logging deterministic
authorBryan C. Mills <bcmills@google.com>
Tue, 7 Jan 2020 20:33:08 +0000 (15:33 -0500)
committerBryan C. Mills <bcmills@google.com>
Thu, 9 Jan 2020 15:38:00 +0000 (15:38 +0000)
commit6dbcc8b8651909442ff823231daba096f447a163
treeef54d8dc6834f17de7506bcc0c555e5312c18d06
parent17e97322fb0605206d8503a321bd24eca17afd34
cmd/go: make "finding" logging deterministic

In CL 204777, I made the "finding" messages in cachingRepo only print
after a “longish” delay, on the theory that they would help diagnose
slow or stuck fetches.

However, as I've been testing Go 1.14 beta 1, I've found that these
messages are mostly just noise, and the fact that they are so
nondeterministic causes both confusion and test flakes (#35539).

Moreover, it currently triggers once for each candidate module, when
what we're usually after is actually a specific package within the
module.

So let's log the package operation unconditionally instead of the
module fetches nondeterministically.

Fixes #35539
Updates #26152

Change-Id: I41a1c772465b2f0b357d3402bc372b6907773741
Reviewed-on: https://go-review.googlesource.com/c/go/+/213679
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/modfetch/cache.go
src/cmd/go/internal/modload/import.go
src/cmd/go/testdata/script/mod_load_badchain.txt