]> Cypherpunks repositories - gostls13.git/commit
cmd/go: refactor -mod flag parsing
authorJay Conrod <jayconrod@google.com>
Wed, 9 Sep 2020 20:35:56 +0000 (16:35 -0400)
committerJay Conrod <jayconrod@google.com>
Fri, 11 Sep 2020 14:22:17 +0000 (14:22 +0000)
commit6e3df749b1058ecfaf5f6601f6f8678c0971da8e
tree100ee42a33775207098a2e8e70f12cd1bc976bed
parentb22af9b407dc29d1a733976484904ad0ab168466
cmd/go: refactor -mod flag parsing

Keep track of whether the -mod flag was set explicitly. When
-mod=readonly is the default, we'll want to adjust our error messages
if it's set explicitly.

Also, register the -mod, -modcacherw, and -modfile flags in functions
in internal/base instead of internal/work. 'go mod' commands that
don't load packages shouldn't depend on internal/work.

For #40728

Change-Id: I272aea9e19908ba37e151baac4ea8630e90f241f
Reviewed-on: https://go-review.googlesource.com/c/go/+/253744
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
14 files changed:
src/cmd/go/internal/base/flag.go
src/cmd/go/internal/cfg/cfg.go
src/cmd/go/internal/fmtcmd/fmt.go
src/cmd/go/internal/modcmd/download.go
src/cmd/go/internal/modcmd/edit.go
src/cmd/go/internal/modcmd/graph.go
src/cmd/go/internal/modcmd/init.go
src/cmd/go/internal/modcmd/tidy.go
src/cmd/go/internal/modcmd/vendor.go
src/cmd/go/internal/modcmd/verify.go
src/cmd/go/internal/modcmd/why.go
src/cmd/go/internal/modload/init.go
src/cmd/go/internal/work/build.go
src/cmd/go/internal/work/init.go