]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] go/types: clarify that contexts do not guarantee deduplication
authorRobert Findley <rfindley@google.com>
Tue, 29 Mar 2022 22:30:06 +0000 (18:30 -0400)
committerHeschi Kreinick <heschi@google.com>
Mon, 9 May 2022 20:28:06 +0000 (20:28 +0000)
commit6fabc53cae6c3f654f9abe4f833b676c6f7172d3
treed6b022efeb831f279fcf7e7da36290e2230e129e
parent2375a6882ee4d4e7566618de1a8c8b45a5dfa3fa
[release-branch.go1.18] go/types: clarify that contexts do not guarantee deduplication

Documentation around the use of types.Context is unclear about whether
contexts guarantee deduplication of identical instances. Add explicit
disclaimers that this is not the case.

Fixes golang/go#52028

Change-Id: I6651587315d3cbf9e8d70a69d3e2ec5cedd00da5
Reviewed-on: https://go-review.googlesource.com/c/go/+/396536
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
(cherry picked from commit 83327b4ae41cf1ef17fb4df4dc395cf17efc6375)
Reviewed-on: https://go-review.googlesource.com/c/go/+/397674
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/compile/internal/types2/context.go
src/cmd/compile/internal/types2/instantiate.go
src/go/types/context.go
src/go/types/instantiate.go