]> Cypherpunks repositories - gostls13.git/commit
cmd/vet: fix go vet on parentheses of assembly function flag
authorWei Xiao <wei.xiao@arm.com>
Mon, 11 Sep 2017 07:59:30 +0000 (07:59 +0000)
committerRob Pike <r@golang.org>
Wed, 13 Sep 2017 03:18:07 +0000 (03:18 +0000)
commit701d49245fcbe9cf095be2afadab0a68986acb72
tree195d4c35ef576ec93775c36a646c34fc80bfcdb5
parent9f1a7192dc574b47f8fae81c16796f808806f032
cmd/vet: fix go vet on parentheses of assembly function flag

Current implementation doesn't recognize parentheses that may appear in flags
of assembly function as shown below:

TEXT ·makeFuncStub(SB),(NOSPLIT|WRAPPER),$24

It results in vet reporting false positives and a lot of whitelists are added
for suppressing the false alarms.

This CL fixes the issue and eliminates the redundant whitelists.

Change-Id: Idbc1b42965b31cea8ee7c23d1a6f62feb68e844c
Reviewed-on: https://go-review.googlesource.com/62850
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/cmd/vet/all/whitelist/386.txt
src/cmd/vet/all/whitelist/amd64.txt
src/cmd/vet/all/whitelist/arm.txt
src/cmd/vet/all/whitelist/arm64.txt
src/cmd/vet/all/whitelist/mips64x.txt
src/cmd/vet/all/whitelist/mipsx.txt
src/cmd/vet/all/whitelist/nacl_amd64p32.txt
src/cmd/vet/all/whitelist/s390x.txt
src/cmd/vet/asmdecl.go