]> Cypherpunks repositories - gostls13.git/commit
runtime: remove unused prefetch functions
authorMartin Möhrmann <moehrmann@google.com>
Mon, 22 May 2017 05:42:42 +0000 (07:42 +0200)
committerMartin Möhrmann <moehrmann@google.com>
Tue, 8 Aug 2017 06:43:49 +0000 (06:43 +0000)
commit7045e6f6c458908e1d5082381b3506a65059eac3
treee9f930d0d0889cc3152c0e08222182f38f696208
parentfd29d03f70238abf460f56209a2ccc76dec6509e
runtime: remove unused prefetch functions

The only non test user of the assembler prefetch functions is the
heapBits.prefetch function which is itself unused.

The runtime prefetch functions have no functionality on most platforms
and are not inlineable since they are written in assembler. The function
call overhead eliminates the performance gains that could be achieved with
prefetching and would degrade performance for platforms where the functions
are no-ops.

If prefetch functions are needed back again later they can be improved
by avoiding the function call overhead and implementing them as intrinsics.

Change-Id: I52c553cf3607ffe09f0441c6e7a0a818cb21117d
Reviewed-on: https://go-review.googlesource.com/44370
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
12 files changed:
src/runtime/asm_386.s
src/runtime/asm_amd64.s
src/runtime/asm_amd64p32.s
src/runtime/asm_arm.s
src/runtime/asm_arm64.s
src/runtime/asm_mips64x.s
src/runtime/asm_mipsx.s
src/runtime/asm_ppc64x.s
src/runtime/asm_s390x.s
src/runtime/mbitmap.go
src/runtime/runtime1.go
src/runtime/stubs.go