]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.7] runtime: improve diagnostics for "scan missed a g"
authorAustin Clements <austin@google.com>
Thu, 17 Nov 2016 15:48:40 +0000 (10:48 -0500)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 25 Jan 2017 17:16:44 +0000 (17:16 +0000)
commit70e980631c52e9705cd92cbc6904ed24f339e2d2
treea2c76e9ebabb4892a9ac2a15452f1a9703c5f065
parent230a376b5a67f0e9341e1fa47e670ff762213c83
[release-branch.go1.7] runtime: improve diagnostics for "scan missed a g"

Updates #18700 (backport)

Currently there are no diagnostics for mark root check during marking.
Fix this by printing out the same diagnostics we print during mark
termination.

Also, drop the allglock before throwing. Holding that across a throw
causes a self-deadlock with tracebackothers.

For #16083.

Change-Id: Ib605f3ae0c17e70704b31d8378274cfaa2307dc2
Reviewed-on: https://go-review.googlesource.com/35677
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/mgcmark.go