]> Cypherpunks repositories - gostls13.git/commit
cmd/link: delete unreachable hash collision check
authorMichael Hudson-Doyle <michael.hudson@canonical.com>
Mon, 21 Mar 2016 06:27:35 +0000 (19:27 +1300)
committerMichael Hudson-Doyle <michael.hudson@canonical.com>
Mon, 21 Mar 2016 06:53:27 +0000 (06:53 +0000)
commit70ef564e795dea06d37e5233fcf3182b231c31f0
treeae0d3dd3284385f62e753367c1f24aa5729a9f72
parentca0f5c97409114f2cd2b30adfca63a4c2bcac0b2
cmd/link: delete unreachable hash collision check

This expression in readsym:

    dup != nil && len(dup.P) > 0 && strings.HasPrefix(s.Name, "gclocals·")

can never be true: if dup != nil, then s.Name is ".dup" (and this is not new:
the same broken logic is present in 1.4, at least). Delete the whole block.

Change-Id: I33b14d9a82b292116d6fd79d22b38e3842501317
Reviewed-on: https://go-review.googlesource.com/20970
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/link/internal/ld/objfile.go