]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/script: check lack of error for non-waiting cmds
authorMichael Matloob <matloob@golang.org>
Fri, 18 Nov 2022 19:33:23 +0000 (14:33 -0500)
committerMichael Matloob <matloob@golang.org>
Fri, 18 Nov 2022 21:02:24 +0000 (21:02 +0000)
commit7161fc737dab823f94d77810953493a0f458284f
tree0e2993e1c6cc33b5c4941f9b90d44e82d8246c7b
parent6fc1f4f906d6d886f324250eebcb44fb4cc39f6c
cmd/go/internal/script: check lack of error for non-waiting cmds

In the script engine, if a command does not return a Wait function and
it succeeds, we won't call checkStatus. That means that commands that
don't have a wait function, have a "!" indicating that they are
supposed to fail, and then succeed will spuriously not fail the script
engine test even they were supposed to fail but didn't.

Change-Id: Ic88c3cdd628064d48f14a8a4a2e97cded48890fb
Reviewed-on: https://go-review.googlesource.com/c/go/+/451284
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
src/cmd/go/internal/script/engine.go
src/cmd/go/testdata/script/list_issue_56509.txt