]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: allow duplicate DWARF producer symbols
authorAustin Clements <austin@google.com>
Thu, 19 Oct 2017 00:14:29 +0000 (20:14 -0400)
committerAustin Clements <austin@google.com>
Thu, 19 Oct 2017 02:56:09 +0000 (02:56 +0000)
commit717d37591d9d446007b830c70ff74d8f8dca13d9
tree64960f34d32a5ee953770038de1d42220178c8da
parent8ce8143f104a72718bdd8a53b4f8d3deba0df47e
cmd/compile: allow duplicate DWARF producer symbols

When building test binaries, we build one archive with all of the test
sources and a second archive with the generated test package main and
link them together. If the test sources are themselves in package main
and the test was compiled with non-default compiler flags, then both
archives will contain a go.cuinfo.producer.main symbol, leading to a
duplicate symbol failure.

This has been causing test build failures on darwin-arm-a1428ios,
darwin-arm64-a1549ios, linux-amd64-noopt, android-arm-wiko-fever, and
android-arm64-wiko-fever since CL 71430 added this symbol. This CL
should fix the build.

Change-Id: I69051c846e7c0d97395a865a361cae07f411f9ad
Reviewed-on: https://go-review.googlesource.com/71771
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/gc/main.go