]> Cypherpunks repositories - gostls13.git/commit
net/http: fix race between dialing and canceling
authorDaniel Morsing <daniel.morsing@gmail.com>
Mon, 20 Apr 2015 22:02:07 +0000 (23:02 +0100)
committerDaniel Morsing <daniel.morsing@gmail.com>
Wed, 22 Apr 2015 12:23:55 +0000 (12:23 +0000)
commit723f86537c362f2f86c82ae827f689c23b866f00
treec9d9d51a09d6a7a134ca87cfbc67a9cd444333c3
parent5fa2d9915f8311d7996e93a3a42cf438278e3886
net/http: fix race between dialing and canceling

In the brief window between getConn and persistConn.roundTrip,
a cancel could end up going missing.

Fix by making it possible to inspect if a cancel function was cleared
and checking if we were canceled before entering roundTrip.

Fixes #10511

Change-Id: If6513e63fbc2edb703e36d6356ccc95a1dc33144
Reviewed-on: https://go-review.googlesource.com/9181
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/export_test.go
src/net/http/transport.go
src/net/http/transport_test.go