]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.9] crypto/x509: skip TestSystemRoots
authorMartin Möhrmann <moehrmann@google.com>
Tue, 22 Aug 2017 18:00:02 +0000 (20:00 +0200)
committerRuss Cox <rsc@golang.org>
Wed, 25 Oct 2017 20:22:39 +0000 (20:22 +0000)
commit724638c9d8cb0ba2dda71eb1fb18f96174f4866f
treed9abd9775937f1f98f4501903feace83606323af
parented3b0d63b72ffb3fc00e98af295a3add20943808
[release-branch.go1.9] crypto/x509: skip TestSystemRoots

golang.org/cl/36941 enabled loading of all trusted certs on darwin
for the non-cgo execSecurityRoots.

The corresponding cgo version golang.org/cl/36942 for systemRootsPool
has not been merged yet.

This tests fails reliably on some darwin systems:
--- FAIL: TestSystemRoots (1.28s)
        root_darwin_test.go:31:     cgo sys roots: 353.552363ms
        root_darwin_test.go:32: non-cgo sys roots: 921.85297ms
        root_darwin_test.go:44: got 169 roots
        root_darwin_test.go:44: got 455 roots
        root_darwin_test.go:73: insufficient overlap between cgo and non-cgo roots; want at least 227, have 168
FAIL
FAIL    crypto/x509     2.445s

Updates #16532
Updates #21416

Change-Id: I52c2c847651fb3621fdb6ab858ebe8e28894c201
Reviewed-on: https://go-review.googlesource.com/57830
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Reviewed-on: https://go-review.googlesource.com/70847
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
src/crypto/x509/root_darwin_test.go