]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.12] fmtsort: sort interfaces deterministically
authorlukechampine <luke.champine@gmail.com>
Thu, 28 Feb 2019 19:03:18 +0000 (19:03 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 13 Mar 2019 20:16:13 +0000 (20:16 +0000)
commit7294ede9610a311576cf4e81c0ed89718e89e39d
tree7e56c66fbd51cb26b9727fca5226938594278439
parentf062f48c1f8862ff0ef7baccf563497339129743
[release-branch.go1.12] fmtsort: sort interfaces deterministically

Previously, the result of sorting a map[interface{}] containing
multiple concrete types was non-deterministic. To ensure consistent
results, sort first by type name, then by concrete value.

Fixes #30484

Change-Id: I10fd4b6a74eefbc87136853af6b2e689bc76ae9d
GitHub-Last-Rev: 1b07f0c275716e1b2834f74f9c67f897bae82882
GitHub-Pull-Request: golang/go#30406
Reviewed-on: https://go-review.googlesource.com/c/163745
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 9d40fadb1c3245a318b155ee3e19a4de139401dc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/164617
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/internal/fmtsort/sort.go
src/internal/fmtsort/sort_test.go